tornado-packages/ethers.js
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix issue when Solidity method collises with JavaScript prototype (#1432, #2054, #2120).

Browse Source
This commit is contained in:
Richard Moore 2021-10-15 21:32:48 -04:00
parent 6582ede1ce
commit 0a8be37b08
No known key found for this signature in database
GPG Key ID: 665176BE8E9DC651
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
packages/contracts/src.ts/index.ts
View File

@ -728,8 +728,8 @@ export class BaseContract {
// are ambiguous // are ambiguous
{ {
const name = fragment.name; const name = fragment.name;
if (!uniqueNames[name]) { uniqueNames[name] = [ ]; } if (!uniqueNames[`%${ name }`]) { uniqueNames[`%${ name }`] = [ ]; }
uniqueNames[name].push(signature); uniqueNames[`%${ name }`].push(signature);
} }
if ((<Contract>this)[signature] == null) { if ((<Contract>this)[signature] == null) {
@ -757,11 +757,13 @@ export class BaseContract {
}); });
Object.keys(uniqueNames).forEach((name) => { Object.keys(uniqueNames).forEach((name) => {
// Ambiguous names to not get attached as bare names // Ambiguous names to not get attached as bare names
const signatures = uniqueNames[name]; const signatures = uniqueNames[name];
if (signatures.length > 1) { return; } if (signatures.length > 1) { return; }
// Strip off the leading "%" used for prototype protection
name = name.substring(1);
const signature = signatures[0]; const signature = signatures[0];
// If overwriting a member property that is null, swallow the error // If overwriting a member property that is null, swallow the error