tornado-packages/ethers.js
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Forward blockchain errors from Signer during gas estimation (#1047).

Browse Source
This commit is contained in:
Richard Moore 2020-09-15 22:14:22 -04:00
parent 263bfe5ce6
commit 9ee685df46
No known key found for this signature in database
GPG Key ID: 665176BE8E9DC651
1 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
packages/abstract-signer/src.ts/index.ts
View File

@ -13,6 +13,12 @@ const allowedTransactionKeys: Array<string> = [
"chainId", "data", "from", "gasLimit", "gasPrice", "nonce", "to", "value" "chainId", "data", "from", "gasLimit", "gasPrice", "nonce", "to", "value"
]; ];
const forwardErrors = [
Logger.errors.INSUFFICIENT_FUNDS,
Logger.errors.NONCE_EXPIRED,
Logger.errors.REPLACEMENT_UNDERPRICED,
];
// Sub-classes of Signer may optionally extend this interface to indicate // Sub-classes of Signer may optionally extend this interface to indicate
// they have a private key available synchronously // they have a private key available synchronously
export interface ExternallyOwnedAccount { export interface ExternallyOwnedAccount {
@ -169,6 +175,10 @@ export abstract class Signer {
if (tx.gasLimit == null) { if (tx.gasLimit == null) {
tx.gasLimit = this.estimateGas(tx).catch((error) => { tx.gasLimit = this.estimateGas(tx).catch((error) => {
if (forwardErrors.indexOf(error.code) >= 0) {
throw error;
}
return logger.throwError("cannot estimate gas; transaction may fail or may require manual gas limit", Logger.errors.UNPREDICTABLE_GAS_LIMIT, { return logger.throwError("cannot estimate gas; transaction may fail or may require manual gas limit", Logger.errors.UNPREDICTABLE_GAS_LIMIT, {
error: error, error: error,
tx: tx tx: tx